Unity version not mentioned; changes required for 2019.4 LTS support

googlesamples / arcore-depth-lab

ARCore Depth Lab is a set of Depth API samples that provides assets using depth for advanced geometry-aware features in AR interaction and rendering. (UIST 2020)

https://augmentedperception.github.io/depthlab/

Apache License 2.0

780 stars 153 forks source link

Unity version not mentioned; changes required for 2019.4 LTS support #6

Closed hybridherbst closed 4 years ago

hybridherbst commented 4 years ago

Current Unity version is 2018.4 LTS.

For 2019.4 LTS, the following packages need to be added:

com.unity.xr.legacyinputhelpers
com.unity.multiplayer-hlapi

kidavid commented 4 years ago

Thank you for the tip, @hybridherbst ! We will consider this change in our next update.

hybridherbst commented 4 years ago

Thanks! One note: common usage of GitHub would be to leave Issues open until they are fixed to avoid other people reporting the same issues... This also allows other users to see issues that are still open when they try to get something to work.

ruofeidu commented 4 years ago

Thank you @hybridherbst for your feedback. We have added the following pointers to README.md.

These samples target Unity 2018.4.16f1 and require ARCore SDK for Unity v1.18.0 or newer.

hybridherbst commented 4 years ago

I think the point of this issue here was to also help other people use it on 2019.4. Why not add the information as well - you can point out that only 2018 is officially supported if that's the concern here. I can tell you that it works fine on 2019 though :)