googlesamples / easypermissions

Simplify Android M system permissions
https://firebaseopensource.com/projects/googlesamples/easypermissions/
Apache License 2.0
9.87k stars 1.46k forks source link

Conductor Controller Integration #225

Closed adin234 closed 6 years ago

adin234 commented 6 years ago

Right now, this library only works with activities and fragments, are there any plans to support Conductor's Controllers?

samtstern commented 6 years ago

@adin234 thanks for the link, I had not heard of the Conductor framework before. EasyPermissions is just meant to be a wrapper over the Android Framework permissions APIs, we don't plan to support every app architecture directly.

It's not possible to make a permissions request without somehow getting hold of an Activity or Fragment reference, even if you're using a View based framework.

As this is not currently our goal I'm going to close this issue, hope that makes sense!

SUPERCILEX commented 6 years ago

Agreed. If you really need to use EP from Conductor, you could always add this hack: (Activity) view.getContext()