search

googlesamples / easypermissions

Simplify Android M system permissions
https://firebaseopensource.com/projects/googlesamples/easypermissions/
Apache License 2.0
9.87k stars 1.46k forks source link

Use in tablet the rationale is too large,even over screen. #288

Closed abiaodev closed 5 years ago

abiaodev commented 5 years ago

Basic Information

Device type: HUAWEI M6 OS version: Android 9 EasyPermissions version: 2.0.1

Describe the problem

The rationale is too large,even over screen. What happened? What did you expect to happen?

Code and logs

// TODO(you): show the code that produces the problem,
//            and any relevant logs.
samtstern commented 5 years ago

@GitABiao could you show a screenshot of how this looks on the device?

abiaodev commented 5 years ago

It`s like this Screenshot_20190906_161443_com abiao arouterdemo

vmadalin commented 5 years ago

@GitABiao Thank you for the screenshot attached, I tried to reproduce it on simulator forcing rotate screen but unfortunately was no been posible. The devices are Nexus 10 and Pixel C with similar screen resolution with Huawei M6 (2.560 x 1.600)

Screenshot 2019-09-09 at 10 27 17

Could you trying to execute the sample project of this library, to discard posible errors with integration. You could reproduce the same error on a different tablet?

androidlpf commented 5 years ago

click cancel

samtstern commented 5 years ago

@GitABiao it would really help if you showed the code you're using to launch the problematic dialog.

abiaodev commented 5 years ago

I have confirmed that the dialog created by Huawei M6 using Android api will also appear in the same situation I sent, it should not be a bug in this framework.

vmadalin commented 5 years ago

@GitABiao That have a lot of sense, basically because the library use the dialog android component for display the rationale message dialog. Thank you for the clarification.

The only solution what I see there is to create a custom view for display, instead the dialog or create an optional callback on request permission method for giving the option to create the user any view their want for show the rationale message, but maybe this is out of scope of library.

samtstern commented 5 years ago

@GitABiao thank you for following up and confirming it wasn't something in our code! I really appreciate it,