search

googlesamples / google-services

A collection of quickstart samples demonstrating the Google APIs for Android and iOS
https://developers.google.com
Apache License 2.0
3.07k stars 2.53k forks source link

iOS9 new app switching UIAlertView isn't handled well. #70

Closed petersibley closed 8 years ago

petersibley commented 9 years ago

Not sure where to report issues with sign in Library itself but I'll share a issue I've spotted today.

In iOS9 on the iPad; Apple added new UX that prompts the user the first time an app request to switch to another app via custom URL protocols and

[[UIApplication sharedApplication] openURL:]

That method returns a BOOL if the openURL call was successful or not. If the user taps OK, then app switch occurs and they can sign in as expected. If they tap Cancel. I'd expect to get invoked on one of the GIDSignInDelegate methods with a NSError object that's not-nil. However no notification is given to the client of the SDK.

This comes up if you're showing any kind of progress indicator UI.

silvolu commented 9 years ago

@petersibley thanks for your feedback! We are working on a fix that will be available in the next release of the library. I'll update this issue when we publish it.

silvolu commented 9 years ago

@petersibley this should be fixed in 2.3.1, can you try it?

silvolu commented 8 years ago

Closing for inactivity.