[Bug report] poseOverlayView is not matched with the preview image in IOS

googlesamples / mlkit

A collection of sample apps to demonstrate how to use Google's ML Kit APIs on Android and iOS

Apache License 2.0

3.55k stars 2.93k forks source link

[Bug report] poseOverlayView is not matched with the preview image in IOS #456

Closed maxoyed closed 2 years ago

maxoyed commented 2 years ago

Describe the bug When I change AVCaptureSession.Preset.medium to AVCaptureSession.Preset.high in function setUpCaptureSessionOutput which in file /ios/quickstarts/vision/VisionExample/CameraViewController.swift, the poseOverlayView is not mathed with the preview image.

4d3a69fc-a6e5-44b6-b3b0-c2a1d6842590

SDK Info:

GoogleMLKit/PoseDetection:2.5.0

Smartphone:

Device: iPhone XR

Development Environment:

IDE Eversion: Xcode 13.2.1
Desktop: iMac Pro (2017)
Desktop OS version: macOS 12.2.1

bcdj commented 2 years ago

The /ios/quickstarts/vision/VisionExample/CameraViewController.swift only implemented the support for AVCaptureSession.Preset.medium. You will need to adapt it to support AVCaptureSession.Preset.high (more than just changing the function setUpCaptureSessionOutput). Likely, you will need to update the logic in normalizedPoint to account for the higher resolution of AVCaptureSession.Preset.high.

bcdj commented 2 years ago

Closing due to inactivity.