Enable Jetifier Popup fails to render properly

MagicMiikka commented 4 years ago

Please fill in the following fields:

Unity editor version: 2018.4.23f1 External Dependency Manager version: 1.2.155 Source you installed EDM (from .unitypackage or Unity Package Manager): PackageManager Features in External Dependency Manager in use (Android Resolver, iOS Resolver, VersionHandler, etc.): All Plugins SDK in use (Firebase, Admob, Facebook, etc.): FireBase, AdMob, Facebook, HelpShift, IronSource Platform you are using the Unity editor on (Mac, Windows, or Linux): Windows Platform you are targeting (iOS, Android, and/or desktop): Android Scripting Runtime (Mono, and/or IL2CPP): IL2CPP

Please describe the issue here:

After Upgrading to 1.2.155 from 1.2.151:

Editor receives a Android SDK not found while at the same time a popup trying to prompt "Enable Jetifier" appears.
Enable Jetifier does not have anything rendered beyond the Title of the box.
You are unable to interact with the button, leaving the editor "frozen"

Please answer the following, if applicable:

What's the issue repro rate? (eg 100%, 1/5 etc) 100% on machines that get the issue. Was able to get it reproed on a previously working computer by clearing the entire repo Library folders and importing the whole project from the beginning.

MagicMiikka commented 4 years ago

I have Resolve during build enabled and here is how it looks: Jetifier

My jetifier setting is set to true in the Android Resolver settings.

alexames commented 4 years ago

Hi @MagicMiikka, sorry for the late reply.

Can you turn on Verbose logging in the settings menu and provide the log here?

If possible, can you provide a minimal complete reproduction case with steps to reproduce?

Also, what is your target and minimum Android API?

Thanks

MagicMiikka commented 4 years ago

Hey @alexames

Min API:19
Target API: 29

Attached a Screenshot of the settings as well

Logs EDM4U Bug.txt

cynthiajoan commented 4 years ago

Hi @MagicMiikka,

There's a potential workaround to solve the dialog pop up, which is resolve first and then build. Could you please try to see if that works?

The real bug here is Unity might reload app bundle in a random time during building, which will wipe out the info in the dialogs. We currently haven't found a way to close the dialogs before reload happens, and would need to do more research to see how to make the fix.

chkuang-g commented 3 years ago

This is probably caused by AppDomain got refreshed and cleared Unity's EditorWindow. https://github.com/googlesamples/unity-jar-resolver/blob/master/source/VersionHandlerImpl/src/DialogWindow.cs

I think you can just enable Jetifier through setting menu. However, there are some other potential pop up occurred during build time.

This can be a bit tedious to fix, since this is the weird behavior of Unity EditorWindow and we cannot control when AppDomain is refreshed.

I think the potential workaround is to just make sure that Android version is installed.

googlesamples / unity-jar-resolver