search

googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.22k stars 339 forks source link

[FR] Abort build if pod install failed #433

Open sp-jordi-vilalta opened 3 years ago

sp-jordi-vilalta commented 3 years ago

Feature proposal

When pod install fails, the iOS Resolver only shows a log message but the build continues: https://github.com/googlesamples/unity-jar-resolver/blob/822d341110f9ecf770f872fdad5f98cbb0531d8b/source/IOSResolver/src/IOSResolver.cs#L2567 Ideally I would like the build to abort because, as the log message says, This will will likely result in an non-functional Xcode project (double "will" BTW), and continuing the process is most likely just a waste of time.

Would it be possible to convert the log into an exception (BuildFailedException?) that aborts the build?

In case you think there's some use case where people may want to continue the build, could we have it as an option? Alternatively, adding a way to query the result of this step would allow us to abort in a later custom step.

google-oss-bot commented 3 years ago

This issue does not seem to follow the issue template. Make sure you provide all the required information.

paulinon commented 3 years ago

Hi @sp-jordi-vilalta,

Thanks for reporting this. I'll be filing a request for this internally so that the team can take a look at this possible feature. I can't give you any timelines for updates regarding this, so I'll leave this open.

sp-jordi-vilalta commented 3 years ago

Thank you @paulinon! If you can confirm that the exception would be an acceptable solution I could probably try the change and open a PR.