search

googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.22k stars 339 forks source link

Change default value of PodToolExecutionViaShellEnabled to be compatible with CocoaPods 11. #488

Closed AlmostMatt closed 2 years ago

AlmostMatt commented 2 years ago

Change default value of PodToolExecutionViaShellEnabled from true to false. When shell execution is disabled, environment variables can be set explicitly for the cocoapods process instead of relying on the user's bash profile. This guarantees that LANG is set to a value that includes utf8, which is necessary when using CocoaPods version 1.11 or higher.

This resolves https://github.com/firebase/quickstart-unity/issues/1149

AlmostMatt commented 2 years ago

Ok, I changed the default value of PodToolExecutionViaShellEnabled back to true. I added a new setting called PodToolShellExecutionSetLang, which causes "export LANG=...; " to be added to the start of the arguments when shell execution is enabled for ios builds.

This requires bash as the tool instead of pod as the tool, which is technically conditional on stdoutRedirectionInShellMode, but that parameter is always true.