Closed andreimamlay closed 2 years ago
This issue does not seem to follow the issue template. Make sure you provide all the required information.
Hi @andreimamlay,
Thanks for reporting this, @andreimamlay. Version 1.2.169 of the resolver has been released recently. Could you confirm if the issue persists using that version as well?
Thank you for your time, @paulinon .
I have
and can confirm, that issue remains: incorrect path delimiter is inserted into maven.url
configuration
In master branch the following code still remains and causes incorrect delimiter on windows platform https://github.com/googlesamples/unity-jar-resolver/blob/8d9505bfaf53468b4412c721d7eff875ec082ca1/source/AndroidResolver/src/PlayServicesResolver.cs#L2146-L2147
Changing said line to
repoUri = String.Format("\"{0}\"",
Path.Combine(projectFileUri, repoPath).Replace("\\", "/"));
would fix the problem on windows platform
Thanks for the information, @andreimamlay. I was able to observe this behavior on a Windows platform as well.
I'll let the team know about this. That being said, I'll be marking this as a bug for now.
There was a PR for this issue!
https://github.com/googlesamples/unity-jar-resolver/pull/421
@paulinon Could you please look again at this issue?
https://github.com/googlesamples/unity-jar-resolver/pull/421 was merged. I am preparing a new release of EDM4U once I got another patch in.
If you need the patch soon, you can rebuild EDM4U using
# Build .unitypackage
./gradlew buildPlugin
# Build .tgz
./gradlew buildUPMPlugin
[REQUIRED] Please fill in the following fields:
[REQUIRED] Please describe the issue here:
Please answer the following, if applicable:
100%
Caused by the following code in PlayServicesResolver.cs
For example,
Path.Combine("file:///C:/Unity/TestGame", "Assets/GeneratedLocalRepo/Firebase/m2repository")
producesfile:///C:/Unity/TestGame\Assets/GeneratedLocalRepo/Firebase/m2repository