googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.21k stars 337 forks source link

Fix iOS Resolver to produce :tvos target podfiles #572

Closed DellaBitta closed 1 year ago

DellaBitta commented 1 year ago

Updates to IOSResolver.cc to handle reading of UnityEditor.PlayerSettings.tvOS.targetOSVersionString for when active build targets are tvOS. Previously the UnityEditor.PlayerSettings.iOS.targetOSVersionString was used.

This work involved:

DellaBitta commented 1 year ago

We spoke offline. The Polling mechanism for the targetSDK values requires that TargetIosSDK and TargetTvosSDK be class properties. Condensing the TargetSDK logic into a single method would probably create even more code than reduce it, as it would simply replicate the code currently in the properties but in a new location with switch/case statements, etc.

So merging this as is for now!