search

googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.21k stars 337 forks source link

Do not explode AARs even if gradle project is not enabled #593

Closed doterax closed 1 year ago

doterax commented 1 year ago

Fixes googlesamples/unity-jar-resolver#584 googlesamples/unity-jar-resolver#287

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ievgenmukhin commented 1 year ago

This fix will be extremely helpful for our projects.

chkuang-g commented 1 year ago

Hey @doterax

Sorry have to revert this change in #612 since it is failing tests.

Let me put together a new PR

chkuang-g commented 1 year ago

Here is the new PR. I will add you guys to review and wait for a week or two for your feedback :)

doterax commented 1 year ago

I reviewed new PR