googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.21k stars 337 forks source link

[Bug] External Dependency Manager fails to resolve the MetaAudienceNetwork dependencies. #642

Closed Davidnovarro closed 9 months ago

Davidnovarro commented 9 months ago

[REQUIRED] Please fill in the following fields:

Apparently when I add MetaAudienceNetwork-3.11.0 Admob adapter External Dependency Manager fails to resolve. Here is the console error message:

Resolution failed
Failed to fetch the following dependencies:
org.jetbrains.kotlin:kotlin-bom:1.8.10

Steps to reproduce:

Download the demo project https://drive.google.com/file/d/1raDeZt11w3lO7tl8L-OHIi1TWwYlfoUq Try to resolve the dependencies: Assets > External Dependency Resolver > Android Resolver > Force Resolve

google-oss-bot commented 9 months ago

This issue does not seem to follow the issue template. Make sure you provide all the required information.

paulinon commented 9 months ago

Hi @Davidnovarro,

Could you try if enabling both Custom Main Gradle Template and Custom Gradle Properties Template from your Player Settings > Publishing Settings resolves the issue? The generated files can handle the resolution better than the custom script in the resolver.

If that doesn't work, does enabling the Jetifier option in Android Resolver settings make any difference?

Davidnovarro commented 9 months ago

Hi @Davidnovarro,

Could you try if enabling both Custom Main Gradle Template and Custom Gradle Properties Template from your Player Settings > Publishing Settings resolves the issue? The generated files can handle the resolution better than the custom script in the resolver.

If that doesn't work, does enabling the Jetifier option in Android Resolver settings make any difference?

Hello, it is impossible for me to enable custom Custom Gradle files because they cause other build issues. The jetifier option is already enabled.

paulinon commented 9 months ago

Thanks for the update, @Davidnovarro. The resolution failed on my end as well, but different dependencies appeared in the error message. Could you provide the error message you encountered when building the app so we can identify what's causing this to happen?

Davidnovarro commented 9 months ago

Thanks for the update, @Davidnovarro. The resolution failed on my end as well, but different dependencies appeared in the error message. Could you provide the error message you encountered when building the app so we can identify what's causing this to happen?

I've already provided

Resolution failed
Failed to fetch the following dependencies:
org.jetbrains.kotlin:kotlin-bom:1.8.10
paulinon commented 9 months ago

Hi @Davidnovarro,

Apologies for the misundertanding. I meant the error message that appears after trying to build when Custom Main Gradle Template and Custom Gradle Properties Template are enabled. Enabling both of them is a common solution whenever there's an issue with resolving dependencies, so if this step fits your use case, it could be something worth looking at.

Davidnovarro commented 9 months ago

Hi @Davidnovarro,

Apologies for the misundertanding. I meant the error message that appears after trying to build when Custom Main Gradle Template and Custom Gradle Properties Template are enabled. Enabling both of them is a common solution whenever there's an issue with resolving dependencies, so if this step fits your use case, it could be something worth looking at.

Hi, in that case the build finishes without any issues. But I don't think that enabling Custom Main Gradle Template is a good solution to this issue :|

paulinon commented 9 months ago

Hi @Davidnovarro,

There may be another solution that's more suitable for your case, but based on the scenario you described, the resolver is exhibiting its intended behavior.

I see that there's a similar issue filed in another repository that's currently under investigation. That said, I'll be closing this ticket for now. Let me know if an issue arises with the resolver.