search

googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.21k stars 336 forks source link

Update AssetDatabase.FindAssets usages return type #684

Closed PeterOlsted-Unity closed 4 weeks ago

PeterOlsted-Unity commented 1 month ago

To ensure AssetDatabase.FindAssets works no matter what the return type is, the variables have been changed to type var instead of string.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

a-maurice commented 1 month ago

This looks good, but do you mind filling out the CLA thing? If you can't, I can just reproduce your changes for you in another PR.

PeterOlsted-Unity commented 4 weeks ago

Hi @a-maurice! I am having difficulty filling out the CLA. Would you mind reproducing the changes? Thanks for taking notice of this PR.

a-maurice commented 4 weeks ago

Done with https://github.com/googlesamples/unity-jar-resolver/pull/687

Thanks for the contribution though!