search

googlesamples / vulkan-basic-samples

Other
498 stars 111 forks source link

pull down from upstream git@github.com:LunarG/VulkanSamples.git #20

Closed ggfan closed 7 years ago

ggfan commented 7 years ago

@bbilodeau @cnorthrop PTAL

cnorthrop commented 7 years ago

We should be able to merge from upstream instead of creating a new commit.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

ggfan commented 7 years ago

yeah, done with merge and kept the readme file to be specific to this repo. run/debug a few ok: draw_cube, spirv-assemble, push_descriptors

cnorthrop commented 7 years ago

Nothing jumps out at me as wrong, but that'a big merge. Maybe do it more often so it is easier to consume. :)

ggfan commented 7 years ago

yeah, should do it more often in monthly or quarterly basis. thx, merging in now.