googlevr / cardboard

Open source Cardboard SDK and samples
Other
1.48k stars 255 forks source link

Add FPS setting to XR Plugin #267

Open dipaw opened 3 years ago

dipaw commented 3 years ago

Hi. Is it possible to limit the fps through a plugin? Unfortunately, many devices do not have active cooling and constant 60 frames is hard to maintain, limiting to 45 and 30 would help a lot.

jballoffet commented 3 years ago

Thanks for reaching out to us. Have you tried using Unity's frame rate setting?

JIC, bear in mind that the Cardboard XR Plugin does not play well with the Optimized Frame Pacing option on Android devices (see https://github.com/googlevr/cardboard/issues/245 for more details).

dipaw commented 3 years ago

Thanks for reaching out to us. Have you tried using Unity's frame rate setting?

JIC, bear in mind that the Cardboard XR Plugin does not play well with the Optimized Frame Pacing option on Android devices (see #245 for more details).

Unfortunately it doesn't work. The only way to change the frame rate in the XR Plugin that I have seen is the API in the Oculus sdk. We need an analogue of this command in Cardboard. Unity.XR.Oculus.Performance.TrySetDisplayRefreshRate(120);

jballoffet commented 3 years ago

Thanks for the details provided. A ticket for adding this feature has been added to our backlog and will be prioritized along with other tickets. We'll update this issue once we have some updates about it. In case you'd like to propose the required changes, please feel free to do so. Patches are welcome.

dipaw commented 3 years ago

Thanks for the details provided. A ticket for adding this feature has been added to our backlog and will be prioritized along with other tickets.

Hi. Perhaps there is a way to enable VSYNC ? Unity VSYNC doesn't work too.