search

googlevr / gvr-android-sdk

Google VR SDK for Android
http://developers.google.com/vr/android/
Other
3.28k stars 1.28k forks source link

It does not build out of the box #601

Open hannesa2 opened 5 years ago

hannesa2 commented 5 years ago

I can't build with recent Android Studio version 3.3

image

After switch to classpath 'com.android.tools.build:gradle:3.3.0' distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip

I run into

FAILURE: Build failed with an exception.

  • What went wrong: Could not resolve all dependencies for configuration ':samples-sdk-controllerclient:classpath'. Project :samples-sdk-controllerclient not found.

Because you don't accept PR, you have to solve it. Thank you

hannesa2 commented 5 years ago

Btw, after I fixed it locally this issue is still open

image
hannesa2 commented 5 years ago

Your logic https://github.com/googlevr/gvr-android-sdk/blob/ffda940638229c1a960e90326275f7c2a029fe1c/settings.gradle#L24 doesn't work anymore

hannesa2 commented 5 years ago

Here https://github.com/googlevr/gvr-android-sdk/pull/602 you see the solution

sewasewa777 commented 5 years ago

602