search

googlevr / gvr-ios-sdk

Google VR SDK for iOS
http://developers.google.com/vr/ios/
Other
645 stars 191 forks source link

Fixes garbage being shown when rendering views with transparency #274

Closed ivanonchi closed 6 years ago

ivanonchi commented 6 years ago

I tried rendering views with transparency (UILabel with clear background, image with transparency in UIImageView, etc.) but there were random colors shown in place of transparency.

I fixed it by clearing the context before using it for view rendering, but then the background was black, so I noticed alpha blending was not enabled.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

ivanonchi commented 6 years ago

Done!

2017-09-24 18:28 GMT+09:00 googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/googlevr/gvr-ios-sdk/pull/274#issuecomment-331698242, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbgbbQUu1La446gJVj7e1Nk7fpb4Mhtks5sliDLgaJpZM4Ph1NI .

googlebot commented 6 years ago

CLAs look good, thanks!

sanjayc77 commented 6 years ago

Thanks for the PR. Unfortunately, we don't maintain the source in Github, rather in an internal repo. We will fix this in the next release. Cheers.