googlevr / gvr-ios-sdk

Google VR SDK for iOS
http://developers.google.com/vr/ios/
Other
645 stars 191 forks source link

- added support for OpenGLES2 #289

Closed grzegorzkrukowski closed 6 years ago

grzegorzkrukowski commented 6 years ago

As discussed here:

https://github.com/googlevr/gvr-ios-sdk/issues/288

there is a problem of GVRKit not running on older devices with openGLES2.

According to Apple documentation:

https://developer.apple.com/library/content/documentation/3DDrawing/Conceptual/OpenGLES_ProgrammingGuide/WorkingwithOpenGLESContexts/WorkingwithOpenGLESContexts.html

It should be initialised as fallback

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


grzegorzkrukowski commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

sanjayc77 commented 6 years ago

Done. Unfortunately we cannot directly merge this into our internal source depot through Github, but this change will show up in the next release.

Thanks for the PR!