googlevr / gvr-ios-sdk

Google VR SDK for iOS
http://developers.google.com/vr/ios/
Other
645 stars 191 forks source link

GVRRendererViewControllerDelegate's didTapTriggerButton not being called #299

Closed ikester closed 6 years ago

ikester commented 6 years ago

I'm building VideoWidgetDemo from the Samples and can't figure out why the didTapTriggerButton method of the GVRRendererViewControllerDelegate is not being called.

I can pause and play the video by tapping when the reticle is on the progress bar button. But if I remove the progress bar view from the GVRSceneRenderer and tap around I can never get the didTapTriggerButton to get called.

According to the code, this should be pretty straightforward:

- (void)didTapTriggerButton {
  // In embedded mode, pass the trigger tap to our delegate.
  if (self.isModal && [self.delegate respondsToSelector:@selector(didTapTriggerButton)]) {
    [self.delegate didTapTriggerButton];
  }
}

Am I not understanding something basic about how this is supposed to work?

sanjayc77 commented 6 years ago

Hmmm, I did not have that issue. I commented out the code which adds the toolbar view (containing the progress bar):

//[sceneRenderer.renderList addRenderObject:viewRenderer];

I can always get didTapTriggerButton to get called.