Inline UnityFromFbx.Set List capacity which improves performance of imports

googlevr / tilt-brush-toolkit

Scripts and assets that help you use Tilt Brush data in your creative projects.

Apache License 2.0

744 stars 164 forks source link

Inline UnityFromFbx.Set List capacity which improves performance of imports #36

Closed mrlinds closed 4 years ago

mrlinds commented 5 years ago

Seems to avoid hangs we were seeing a lot of. We import several very large tiltbush fbx's into unity and were seeing unity hang, I assume the hang is memory related so set capacity for lists and threw a clear in there in a couple cases that didn't seem to break, but am not sure how necessary that is. The inlining I did as I've seen in realtime application that this helps when dealing with Unity Vector operations, especially over potential several hundred thousand vertices or uv's.

dubois commented 5 years ago

ping @googlebot

dubois commented 5 years ago

I happen to be working in this area right now so some of these review comments may be addressed by a commit of my own in the next couple days

dubois commented 5 years ago

Hey MrLinds, try latest and see if that works for you!

dubois commented 4 years ago

I landed some perf improvements a while back, and I now recommend that you use .glb since it requires fewer shenanigans to squeeze through all our vertex info (and it includes timestamp information). I'll close, but feel free to reopen if you still have issues.