search

googleworkspace / android-samples

Android samples for Google Workspace APIs
Apache License 2.0
636 stars 410 forks source link

Reason for extending AsyncTask with ApiClientAsyncTask ? #38

Closed seanpjanson closed 9 years ago

seanpjanson commented 9 years ago

I've noticed that the AsyncTask has been extended with ApiClientAsyncTask on Feb 17,2014. There is no documentation or reason given for this extension and I can't figure out why is that necessary. Can the author of this change ('rakyll)' enlighten me on this issue?

nabinkhadka commented 9 years ago

Where? @seanpjanson Thank you

seanpjanson commented 9 years ago

here

kroikie commented 9 years ago

Looks like a convenience change to me. Since all of the AsyncTasks in the sample are doing some interaction with GoogleApiClient. @seanpjanson is there something about this that concerns you?

seanpjanson commented 9 years ago

No, just an unexplained code. Nothing that a sentence or two wouldn't fix.

kroikie commented 9 years ago

Cool, I think it was mainly to reduce repetition of GoogleApiClient similar to what happens with BaseDemoActivity.