googleworkspace / apps-script-oauth2

An OAuth2 library for Google Apps Script.
https://developers.google.com/apps-script/
Apache License 2.0
1.56k stars 429 forks source link

Update out of date packages and remove the node-fiber dependency #364

Closed sqrrrl closed 2 years ago

sqrrrl commented 2 years ago

Updates 3P packages to current versions and removes node-fiber. Node-fiber is no longer supported and is considered obsolete, and also causes node 16+ to crash. Rewrites a few tests + mocks to no longer depend on it.

Unfortunate side effect is the tests for locking aren't testing thread safety any more. It might be possible in the future to recreate apps script semantics via worker threads. For now, this relaxes the tests so builds aren't locked in to old versions of node.

jpoehnelt commented 2 years ago

Might need to rebase on main branch

sqrrrl commented 2 years ago

Yeah, was trying to rebase locally but just got into a weird state. Reapplied the original changes in a new branch in #390.