googleworkspace / apps-script-samples

Apps Script samples for Google Workspace products.

https://developers.google.com/apps-script

Apache License 2.0

4.49k stars 1.83k forks source link

feat(calendar): Fixed broken link and added support for indirect members or multiple groups to Team Calendar #390

Closed lwcorp closed 1 year ago

lwcorp commented 1 year ago

Description

Fixed a broken link in the README to the vacation calendar script. Without this fix, users may not find this script.
Added a feature to the vacation to also support indirect members or multiple groups. Without it the calendar is limited since many groups also contain indirect members and there was no alternative to manually specify multiple groups.

Is it been tested?

[X] Production testing done

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have performed a peer-reviewed with team member(s)
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] Any dependent changes have been merged and published in downstream modules

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lwcorp commented 1 year ago

Thanks for the approval! Do you think you can update Populate a team vacation calendar (or more specifically the production script) with these features?

jpoehnelt commented 1 year ago

It should update within about 24 hours.

lwcorp commented 1 year ago

It should update within about 24 hours.

Any update on this? Almost 2 days passed:

jpoehnelt commented 1 year ago

Where did you find a link to that?

lwcorp commented 1 year ago

https://developers.google.com/apps-script/samples/automations/vacation-calendar

lwcorp commented 1 year ago

Where did you find a link to that?

Did you have a chance to review that link?

lwcorp commented 8 months ago

Thanks for finally integrating it after all these months! It's good to start 2024 with my added features in your script. You had to update the official script because of this bug, but maybe you should regularly sync it with GitHub instead of relying on custom copy/paste that you do only after serious bugs.