search

googleworkspace / apps-script-samples

Apps Script samples for Google Workspace products.
https://developers.google.com/apps-script
Apache License 2.0
4.49k stars 1.83k forks source link

.clasp.json will be overwrited for people using clasp to upload GAS to their own projects #431

Open brentchang opened 9 months ago

brentchang commented 9 months ago

Summary

The .clasp.json files contain the GAS project IDs only accessible inside Google. (example) However, people using clasp CLI to push to their GAS project ID will need to overwrite these files.

What I think it might be better in either way:

  1. add .clasp.json in .gitignore file but it will not work since this file is required for your Github Actions Workflow.
  2. rename the Google-only accessible .clasp.json to other filename instead of default .clasp.json, while rename them back to .clasp.json before executing clasp push -f(link) inside your Github Action Workflow

Expected Behavior

People not work at Google can clone/commit this repo without overwriting this .clasp.json file.

Actual Behavior

Everyone outside Google needs to overwrite this .clasp.json file to run the clasp push to their GAS project.

Steps to Reproduce the Problem

  1. login with personal gmail account
  2. create a new Google Sheet and retrieve the GAS project ID through Extensions > Apps Script menu
  3. Go to Project Settings to retrieve Script ID
  4. Overwrite the scriptID within solutions/automations/mail-merge/.clasp.google-only.json
  5. run clasp push under solutions/automations/mail-merge/ directory

But I have no idea how Googlers use these .clasp.json files, so feel free to provide any other idea, thanks!

o23bsr0620-capke commented 8 months ago

Has solutions??

brentchang commented 8 months ago

Yes, based on my second idea, I created the PR as a solution.

https://github.com/googleworkspace/apps-script-samples/pull/432