Open quinton-ashley opened 1 year ago
google-cla[bot]
commented
1 year ago Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
quinton-ashley
commented
1 year ago I signed the Google CLA, please update this project ASAP it is very useful and it'd be great if people could still use it in 2023 and beyond.
quinton-ashley
commented
1 year ago @sqrrrl will this be merged?
fbitti
commented
1 year ago This pull request also fails on
% sw_vers ProductName: macOS ProductVersion: 13.4.1 ProductVersionExtra: (c) BuildVersion: 22F770820d
I tried without sudo and with sudo.
Additional logs:
% sudo npm install -g md2gslides
Password:
npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated left-pad@1.3.0: use String.prototype.padStart()
npm WARN deprecated source-map-url@0.3.0: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated source-map-resolve@0.3.1: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated axios@0.18.1: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated highlight.js@9.18.5: Support has ended for 9.x series. Upgrade to @latest
npm WARN deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code 1
npm ERR! path /usr/local/lib/node_modules/md2gslides/node_modules/sharp
npm ERR! command failed
npm ERR! command sh -c (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)
npm ERR! TOUCH Release/obj.target/libvips-cpp.stamp
npm ERR! CXX(target) Release/obj.target/sharp/src/common.o
npm ERR! info sharp Using cached /Users/<REDACTED_USER>/.npm/_libvips/libvips-8.9.0-darwin-x64.tar.gz
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@9.4.0
npm ERR! gyp info using node@19.8.1 | darwin | x64
npm ERR! gyp info find Python using Python version 3.11.4 found at "/usr/local/opt/python@3.11/bin/python3.11"
npm ERR! gyp info spawn /usr/local/opt/python@3.11/bin/python3.11
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args 'binding.gyp',
npm ERR! gyp info spawn args '-f',
npm ERR! gyp info spawn args 'make',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/usr/local/lib/node_modules/md2gslides/node_modules/sharp/build/config.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/common.gypi',
npm ERR! gyp info spawn args '-Dlibrary=shared_library',
npm ERR! gyp info spawn args '-Dvisibility=default',
npm ERR! gyp info spawn args '-Dnode_root_dir=/Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1',
npm ERR! gyp info spawn args '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args '-Dnode_lib_file=/Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/<(target_arch)/node.lib',
npm ERR! gyp info spawn args '-Dmodule_root_dir=/usr/local/lib/node_modules/md2gslides/node_modules/sharp',
npm ERR! gyp info spawn args '-Dnode_engine=v8',
npm ERR! gyp info spawn args '--depth=.',
npm ERR! gyp info spawn args '--no-parallel',
npm ERR! gyp info spawn args '--generator-output',
npm ERR! gyp info spawn args 'build',
npm ERR! gyp info spawn args '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! In file included from ../src/common.cc:22:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/node.h:73:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8.h:24:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-array-buffer.h:12:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-local-handle.h:12:
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:477:30: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! SHARED_EXTERNAL_POINTER_TAGS(CHECK_SHARED_EXTERNAL_POINTER_TAGS)
npm ERR! ^
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:477:30: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:477:30: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:477:30: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:477:30: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! PER_ISOLATE_EXTERNAL_POINTER_TAGS(CHECK_NON_SHARED_EXTERNAL_POINTER_TAGS)
npm ERR! ^
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:478:35: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:659:61: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! static_assert(kJSObjectType + 1 == kFirstJSApiObjectType);
npm ERR! ^
npm ERR! , ""
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:660:55: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! static_assert(kJSObjectType < kLastJSApiObjectType);
npm ERR! ^
npm ERR! , ""
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:661:63: warning: 'static_assert' with no message is a C++17 extension [-Wc++17-extensions]
npm ERR! static_assert(kFirstJSApiObjectType < kLastJSApiObjectType);
npm ERR! ^
npm ERR! , ""
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-internal.h:851:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
npm ERR! !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
npm ERR! ~~~~~^~~~~~~~~~~
npm ERR! remove_cv
npm ERR! /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__type_traits/remove_cv.h:22:50: note: 'remove_cv' declared here
npm ERR! template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
npm ERR! ^
npm ERR! In file included from ../src/common.cc:22:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/node.h:73:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8.h:24:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-array-buffer.h:13:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-object.h:9:
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-maybe.h:106:27: error: no template named 'enable_if_t' in namespace 'std'
npm ERR! template <class U, std::enable_if_t<!std::is_lvalue_reference_v<U>>*>
npm ERR! ~~~~~^
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-maybe.h:106:45: error: no template named 'is_lvalue_reference_v' in namespace 'std'; did you mean 'is_lvalue_reference'?
npm ERR! template <class U, std::enable_if_t<!std::is_lvalue_reference_v<U>>*>
npm ERR! ~~~~~^~~~~~~~~~~~~~~~~~~~~
npm ERR! is_lvalue_reference
npm ERR! /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__type_traits/is_reference.h:26:29: note: 'is_lvalue_reference' declared here
npm ERR! struct _LIBCPP_TEMPLATE_VIS is_lvalue_reference : _BoolConstant<__is_lvalue_reference(_Tp)> { };
npm ERR! ^
npm ERR! In file included from ../src/common.cc:22:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/node.h:73:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8.h:24:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-array-buffer.h:13:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-object.h:9:
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-maybe.h:106:69: error: expected '(' for function-style cast or type construction
npm ERR! template <class U, std::enable_if_t<!std::is_lvalue_reference_v<U>>*>
npm ERR! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-maybe.h:123:25: error: no template named 'enable_if_t' in namespace 'std'
npm ERR! template <class T, std::enable_if_t<!std::is_lvalue_reference_v<T>>* = nullptr>
npm ERR! ~~~~~^
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-maybe.h:123:43: error: no template named 'is_lvalue_reference_v' in namespace 'std'; did you mean 'is_lvalue_reference'?
npm ERR! template <class T, std::enable_if_t<!std::is_lvalue_reference_v<T>>* = nullptr>
npm ERR! ~~~~~^~~~~~~~~~~~~~~~~~~~~
npm ERR! is_lvalue_reference
npm ERR! /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__type_traits/is_reference.h:26:29: note: 'is_lvalue_reference' declared here
npm ERR! struct _LIBCPP_TEMPLATE_VIS is_lvalue_reference : _BoolConstant<__is_lvalue_reference(_Tp)> { };
npm ERR! ^
npm ERR! In file included from ../src/common.cc:22:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/node.h:73:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8.h:24:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-array-buffer.h:13:
npm ERR! In file included from /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-object.h:9:
npm ERR! /Users/<REDACTED_USER>/Library/Caches/node-gyp/19.8.1/include/node/v8-maybe.h:123:67: error: expected '(' for function-style cast or type construction
npm ERR! template <class T, std::enable_if_t<!std::is_lvalue_reference_v<T>>* = nullptr>
npm ERR! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
npm ERR! 20 warnings and 7 errors generated.
npm ERR! make: *** [Release/obj.target/sharp/src/common.o] Error 1
npm ERR! gyp ERR! build error
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:203:23)
npm ERR! gyp ERR! stack at ChildProcess.emit (node:events:512:28)
npm ERR! gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:293:12)
npm ERR! gyp ERR! System Darwin 22.5.0
npm ERR! gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /usr/local/lib/node_modules/md2gslides/node_modules/sharp
npm ERR! gyp ERR! node -v v19.8.1
npm ERR! gyp ERR! node-gyp -v v9.4.0
npm ERR! gyp ERR! not ok
npm ERR! A complete log of this run can be found in: /Users/<REDACTED_USER>/.npm/_logs/2023-08-13T14_07_09_806Z-debug-0.log
After making updates and a few changes I got the example.md to be converted to slides! I'm using the latest versions of macOS (v13.0.1) and nodejs v18.12.1
I couldn't figure out how to get the mocha tests to run though, I'm not familiar with mocha or typescript.
The readme for this project should also be updated to explain how to add testers to google apps.