goonstation / api

Goonhub API v2 (and Goonhub)
https://goonhub.com
1 stars 3 forks source link

Detecting of round end is wonky. #16

Closed mordent-goonstation closed 6 months ago

mordent-goonstation commented 6 months ago

https://goonhub.com/admin/logs?sort_by=ended_at

image

Currently an entire page (and one extra row) of "Round in progress" rounds.

Examining one of those rounds shows "In Progress" in the top right, even though it isn't.

I would expect to see only rounds that are actually in progress show as in progress. I would imagine this is to do with how round end is determined, and possibly coincides with hard restarts.

Wirewraith commented 6 months ago

Fixed with https://github.com/goonstation/api/commit/05924f5d50beb184d26b4800729b55e1db33e45b