search

goonstation / goonstation

Repository for the Goonstation branch of SS13
https://goonhub.com
Other
325 stars 1.36k forks source link

Many radio signals are no longer forwarded to (through?) the mainframe #9845

Open The-Grim-Sleeper opened 2 years ago

The-Grim-Sleeper commented 2 years ago

Labels

[BUG] [MINOR]

Description

Many auto-generated PDA messages, as well as the wifi-messages of doors and airlocks (141.1) are not found in the wired network or the mainframe radio logs.

Steps to reproduce

The mainframe /mnt/radio/#### folders contain text files of all radio traffic on the station. Eg, if the directory /mnt/radio/1149 exists and you use the PDA->messages->scan(for new PDA addresses), the there will be a file /mnt/radio/1149/WT07241325, which contains the text command=report_pda\nsender=0202bcaf\n_freq=1149. Normally, there should also be a bunch of a whole bunch of files of similar XX######## name, containing command=report_reply; address_1=0202bcaf; owner=Captain; sender=02038a1e; These auto-generated PDA messages, as well as the wifi-messages of doors and airlocks (141.1) are not present. If my quick tests are correct (rough round) the guardbuddy status messages are also not logged if /mnt/radio/1219/ exists.

To reproduce the (lack of) Door Wifi messages:

  1. Go to any DWAINE terminal, login, type ls /mnt/radio/1411/; the reply could be No files.
  2. Open any door on the station
  3. Go back to any DWAINE terminal, login, type ls /mnt/radio/1411/; there SHOULD be an new file, containing the door address, a timestamp, a ID-card name etc
    • you can keep track of the signal with a PDA with a 'Analysis Made Easy cartridge' and use the app 'packet sniffer' with frequency 141.1; the sniffer will show the interaction with the same door address, a timestamp, a ID-card name

To reproduce the (lack of) PDA messages

  1. Start game, enter round, get a PDA with a 'Analysis Made Easy cartridge' inserted (or similar wifi analizing tool)
  2. Go to any DWAINE terminal, login and get Super User access.
  3. type mkdir /mnt/radio/1149/
  4. type ls /mnt/radio/1411/; the reply will be No files.
  5. use any PDA, go to Messenger, click scan; this will update the PDA SpaceMessenger list with numerous 'Detected PDAs'
  6. type ls /mnt/radio/1411/; the reply will have 1 file, but there SHOULD BE many files (1 file for every PDA that send/recieve turned on)
    • with the PDA packet sniffer, you will see all these command=report_reply messages as expected.

Expected Behavior

The auto generated PDA messages should also show up in the mainframe radio logs.

Additional Information & Screenshots

No response

Vincent983 commented 7 months ago

Are you sure that the door wifi messages not reaching to the mainframe is not simply due to them having an extremely small broadcast range?

The-Grim-Sleeper commented 7 months ago

Oof, it's been ages. Iirc I tried various devices and radio messages: doors, buddy-bots, PDA-messages. But I haven't played since november 2022, i have no idea what the current state is.

klookiyam commented 2 weeks ago

I think this happened around this commit: https://github.com/goonstation/goonstation/pull/6437. The mainframe radio now only seems to record packets that are directly addressed to it or sent to a group. It could probably be fixed by calling update_all_hearing(TRUE) on frequencies added here.

I wouldn't want to make the change without doing some profiling, as this would reintroduce a massive amount of packets being recorded, and I'm not sure what the performance implications are.