search

goopypanther / saucebot-discord

17 stars 13 forks source link

Pixiv image set now embed all images #10

Open bootresha opened 4 years ago

bootresha commented 4 years ago

Hi mate, I really liked this discord bot you have!

However, I do notice that when dealing with pixiv link that has multiple images, it only embeds the first image. I imagine this could be because you do that on purpose. But in case it wasn't, I added that feature now in this newer version of your script

Let me know what you think!

bootresha commented 4 years ago

Forgot to mention, this is tested on my end and it seems to work at least. if you push this to the bot you have already deployed to public, I'd be very happy!

jmattousey commented 4 years ago

Cheers good work on this I was trying to get it to work on my own end but couldn't manage it myself

bootresha commented 4 years ago

Glad to be able to help!

jmattousey commented 4 years ago

Hopefully the owner pulls it in. I have my own pull request that changes some of the pixiv code because you no longer need any credentials to use pixiv api

bootresha commented 4 years ago

Wait, really? I should probably check your pull request

jmattousey commented 4 years ago

I don't believe ours overlap as far as I know

goopypanther commented 4 years ago

I would be okay with the bot posting a couple images from a pixiv imageset with a message noting if there's more, the issue is there's no length limit for these imagesets and I don't want to enable people to spam discord channels by posting a link to a 20+ image set (I've seen longer ones that that too). Its the kind of thing that results in admins removing the bot from their servers.

The second issue is that in order to bypass pixiv's antihotlinking feature the bot loads each image into memory and uploads it to discord which ends up being rather taxing on my low memory VPS when people from dozens of servers use it at once.

bootresha commented 4 years ago

All good, I figured that would be the reason. Would you be more okay if I change it so that it only posts 10 images at most?