search

gootik / rebar_cmd

A rebar plugin for running custom commands
Other
16 stars 3 forks source link

os:cmd instead of Erlang ports #23

Closed paulo-ferraz-oliveira closed 4 years ago

paulo-ferraz-oliveira commented 4 years ago

Attempting to [Fix #16] [Fix #21] [Fix #22], by replacing Erlang ports with os:cmd as discussed in two of the linked Issues.

paulo-ferraz-oliveira commented 4 years ago

I pushed a fix for the tests. I also ended up having erlfmt inside its own profile, because it'll only run in Erlang/OTP 21+ and it was thus restricting the "plugin" which can support from 19.3 on (the same versions rebar3 supports).

paulo-ferraz-oliveira commented 4 years ago

Hurrah, tests passed. Don't merge just yet. I'm tweaking the README.md.

Edit: you can see how it looks here.

gootik commented 4 years ago

nicely done. I'll merge this now and anything that you like to improve on can be separate PRs. Again, thank you so much for doing all of this. really appreciate it

paulo-ferraz-oliveira commented 4 years ago

If you feel it's OK, could you release it and possibly publish it to Hex? Thanks.