Feedback & suggestions

[jimmyff]

Hi @gopaldhola99, really nice plugin. Great work! I've been having a play with it in my app and made a couple of tweaks in my own fork and got a few suggestions too:

Minor tweaks:

• I've added child parameter to the StickerView this seems pretty essential for likely the most common use case of this plugin being sticking an image
• I got rid of ImageQuality enum and simply replaced it with a pixelRatio parameter. This again is pretty important so you can output images at necessary & exact sizes /
• I standardised the UI code for _ResizePoint and _FloatingActionIcon
• I've added an aspectRatio optional parameter to the Sticker
• I've moved the _initialStickerScale in to the individual stickers

Things I'd like to add:

• Ability to have granular control over if a sticker can be moved, scaled, edited, deleted - this would work nicely for something like a watermark
• A way of setting the initial position of stickers. Possibly updating their position programatically too as it is possible to move a sticker out of view, and then you have no way of getting back.
• A way of reordering the Z value of the stickers programatically. So the app could have a layers UI
• buttonStyle & primary color for retheming

Feedback & discussion

• I think it would be a huge improvement to be able to see the sticker outline & action buttons overflowing outside of the StickerView. Sometimes when placing images you will often need to position them in a place that hides the controls. I've had a play looking at OverflowBox but not had any success. Not sure if you have ideas for this?
• Panning and zooming the whole StickerView would be nice, I had a very quick play with InteractiveViewer but didn't have any luck with it. This would really elevate the plugin and make it a very handy tool for precision stickering! ;)
• Changing StickerView box size (eg: due to device orientation change) does not translate the stickers scale & position accordingly. Again something that would be a very worthwhile addition. Probably wouldn't be too much work
• There a little issue when you start rotating a sticker, it seems to rotate really quickly at first. I had a little look at the code but couldn't wrap my head around the maths
• Not sure why isText is required, if a Sticker is just a widget, and there are edit button callbacks, then leave the text edit UI etc to the app creator. Stickers can just be treated equally. Or perhaps a TextSticker class could exist which hold the String. Even in this case isText shouldn't be necessary

I'm happy to send a pull request with any changes I make but I thought I should check that you are open for PRs atm. I know the plugin is in early stages and a few todo's dotted around the code so there is a good chance you have a plan for some of the above!

Thanks, Jimmy

[jimmyff]

Hey @gopaldhola99 I've added StickerController to my fork, currently it only allows the parent of StickerView to fire the SelectNone action which is useful for saving the image. At the moment it uses enums but I don't think they be sufficient for more advanced interactions such as reordering layers etc. Perhaps we would need it to use classes. Let me know your thoughts regarding the inclusion of a controller class.

I've noticed the code is 5 months old, I actually came across the package whilst in transit and failed to not ice that. Do you you plan to continue working on Stickerview or should I continue with my own fork?

Thanks

[jeeldev9]

@jimmyff can you send me your forked project?

[jimmyff]

Hey @jeeldev9, I actually ended up creating something entirely bespoke for my project so I could achieve all of my feedback points above. At the moment it's tied quite specifically to my application so would requite some work to publish but I may do that further down the line

[Dev-Adnani]

Hey @jimmyff Did you work on a new package ? (For Sticker View)

[KlausJuhantalo]

@jimmyff Please update this...