search

gopasspw / gopass-jsonapi

Gopass Browser Bindings
MIT License
50 stars 18 forks source link

Reports the version incompatible with Gopass Bridge. #2

Closed vdrandom closed 3 years ago

vdrandom commented 3 years ago

When splitting functionality between projects like that, please at least report a semblance of a proper version maybe?

Gopass Bridge complains about gopass-jsonapi version again since it is clearly lower than 1.8.5. And I wouldn't mind that, but no automatic search for hostname happens in this case.

> gopass-jsonapi --version
gopass-jsonapi version 0.0.1
vdrandom commented 3 years ago

Also the fact that new version of gopass stripped of this functionality was released while jsonapi part wasn't looks like a dick move. (At first I thought that's on the package maintainer, but no, it seems like you moved jsonapi into a separate project without actually making a release.)

giffels commented 3 years ago

Same here. As a workaround you can set the version to 1.8.5 in https://github.com/gopasspw/gopass-jsonapi/blob/dc7295fcd713f9adf7ba6f2890fad267ff2cd9a7/VERSION#L1

This was not a really sophisticated move, please fix it.

Thanks!

dominikschulz commented 3 years ago

@vdrandom Lol. While your complaint is certainly correct, your choice of words is not. @giffels Sorry for that. I take the blame for not coordinating with the gopassbridge maintainers better, but unfortunately I haven't seen much activity here and I don't feel responsible for gopassbridge or the jsonapi myself - one of the reasons why we did move it.

Pharb commented 3 years ago

Thanks for reporting this. Sorry for the rough first steps here in the new repository. I will try to release the current version so it can be used by gopassbridge (see #3).

vdrandom commented 3 years ago

@dominikschulz well I was understood, that's what matters the most. I probably overexaggerated and wasn't polite enough. I apologize for that.

Cheers and thanks. While it is easy enough to fix on one's own by modifying a single file, hopefully less people will have to do that.