Please add support for LibreWolf

[NuLL3rr0r]

Summary

For privacy concerns, I've switched from Brave to LibreWolf, which is a solid Firefox/Brave alternative without the annoyances of Firefox. I've noticed gopass-jsonapi is not able to set up the Gopass bridge.

Steps To Reproduce

!. Install LibreWolf

2. Install Gopass extension
3. Try to configure using gopass-jsonapi

Expected behavior

LibreWolf is not different from Firefox that much, except for being hardened for privacy. This should be easy to set up and work.

Environment

• OS: Gentoo
• OS version: Linux mamadou-legion 5.15.50 # 34 SMP Tue Jun 28 16:56:47 CEST 2022 x86_64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz GenuineIntel GNU/Linux
• gopass-jsonapi Version: gopass-jsonapi version 1.11.1
• Installation method: My own custom ebuilds

Additional context

BTW, I've noticed the version is being reported as 1.11.1 by gopass-jsonapi. Looking at the repository/VERSION file it seems it contains the wrong version string. I'm running 1.14.3 at the moment.

[dominikschulz]

Thanks for the suggestion. Sounds like a valid feature request.

But the version issue should be tracked separately.

[NuLL3rr0r]

For the version, it should be possible to extract the git tag inside the Makefile from Git executable. If that sounds like a good idea, I could make a pull request for it.

This is what, I usually do:

GIT_BRANCH  :=  $(shell git rev-parse --abbrev-ref HEAD)
GIT_TAG     :=  $(shell git describe --tags --abbrev=0 2>/dev/null)
GIT_COMMIT  :=  $(shell git rev-parse --short HEAD)
GIT_TREE_STATE  :=  $(shell test -n "`git status --porcelain`" && echo "dirty" || echo "clean")

ifeq ($(GIT_BRANCH),master)
ifeq ($(strip $(GIT_TAG)),)
ifeq ($(GIT_TREE_STATE),dirty)
VERSION := v0.0.0-${GIT_COMMIT}*
else # ($(GIT_TREE_STATE),dirty)
VERSION := v0.0.0-${GIT_COMMIT}
endif # ($(GIT_TREE_STATE),dirty)
else # ($(strip GIT_TAG),)
ifeq ($(GIT_TREE_STATE),dirty)
VERSION := ${GIT_TAG}-${GIT_COMMIT}*
else # ($(GIT_TREE_STATE),dirty)
VERSION := ${GIT_TAG}-${GIT_COMMIT}
endif # ($(GIT_TREE_STATE),dirty)
endif # ($(strip GIT_TAG),)
else # ($(GIT_BRANCH),master)
ifeq ($(GIT_TREE_STATE),dirty)
VERSION := ${GIT_BRANCH}-${GIT_COMMIT}*
else # ($(GIT_TREE_STATE),dirty)
VERSION := ${GIT_BRANCH}-${GIT_COMMIT}
endif # ($(GIT_TREE_STATE),dirty)
endif # ($(GIT_BRANCH),master)

VERSION_MAJOR = $(shell echo ${GIT_TAG} | cut -d '.' -f 1 | tr -d -c 0-9)
ifeq ($(VERSION_MAJOR),)
VERSION_MAJOR := 0
endif

VERSION_MINOR = $(shell echo ${GIT_TAG} | cut -d '.' -f 2 | tr -d -c 0-9)
ifeq ($(VERSION_MINOR),)
VERSION_MINOR := 0
endif

VERSION_PATCH = $(shell echo ${GIT_TAG} | cut -d '.' -f 3 | tr -d -c 0-9)
ifeq ($(VERSION_PATCH),)
VERSION_PATCH := 0
endif