Open jmpolom opened 1 year ago
I just ran into the same bug using gopass 1.15.12.
I fail to reproduce with 1.15.12, I'm afraid.
@jmpolom The instructions are good but I think I'm missing a few steps before 1. How to you initialize the root and sub stores?
Hey! I started over and created a new reproducer. Here's what I did:
rm -rf ~/.local/share/gopass ~/.config/gopass ~/.cache/gopass
age
and giving the proper identity: Obviously the secrets were never encrypted for the additional recipient. This can also be seen when looking at the age files in raw mode.
Here's a debug log of the step that failed when we added the recipient.: gopass-reproducer-debug-log-add-github.log
Please let me know if I should try something else! Thanks for your help and this great project!
I'll try to reproduce this now that I've touched much of the code handling this in #2960
Thx for getting back to this @AnomalRoil ! Much appreciated!
Summary
Adding a recipient to an age encrypted gopass substore fails when gopass attemps to add re-encrypted files to git repo
Steps To Reproduce
gopass clone --crypto age https://git.repo.com/path/to/pass.git test-pass-sub
gopass ls
to verify that substore is mounted at test-pass-subgopass recipients
gopass recipients add --store test-pass-sub age1<...>
gopass git --store test-pass-sub status
and notice many changed files not staged for commit.To me it appears git is being called from the wrong directory or paths are being specified incorrectly. The issue can be manually corrected by adding the files with
git add
, committing and pushing however this should not be necessary.Expected behavior
Recipient can successfully be added without git error and manual recovery, as appears to be the case for the "root" store.
Environment
Linux hostname 6.1.6-100.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Jan 14 17:00:40 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Additional context
None.