search

gopasspw / gopassbridge

A web extension for Firefox and Chrome to insert login credentials from gopass
MIT License
264 stars 24 forks source link

Add tooltips to search result buttons #144

Closed kristiankostadinov closed 4 years ago

kristiankostadinov commented 4 years ago

As mentioned in #73

codecov[bot] commented 4 years ago

Codecov Report

Merging #144 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #144   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         588    590    +2     
  Branches      102    101    -1     
=====================================
+ Hits          588    590    +2
Impacted Files Coverage Δ
web-extension/search.js 100% <100%> (ø) :arrow_up:
web-extension/generic.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecd0a0d...07a6638. Read the comment docs.

Pharb commented 4 years ago

Thanks a lot @kristiankostadinov for your effort to improve the UI.

I will try to review your changes in the next few days, but until then it would help a lot if you could provide some screenshots showing your UI changes in Chrome and Firefox and post them here as comments.

kristiankostadinov commented 4 years ago

Hi, here are some screenshots:

Chrome

chrome

Firefox

firefox

martinhoefling commented 4 years ago

@kristiankostadinov , looks really nice! Thx.

Pharb commented 4 years ago

Looks good, thanks 👍

Pharb commented 4 years ago

Thanks again @kristiankostadinov, your changes are now live on Firefox in v0.7.0, Chrome release is still pending review...