search

gopasspw / gopassbridge

A web extension for Firefox and Chrome to insert login credentials from gopass
MIT License
264 stars 24 forks source link

[v1.9.3-rc.0 incompatibility] comand 'gopass jsonapi configure' is not recognized #163

Closed glowinthedark closed 4 years ago

glowinthedark commented 4 years ago

Running the command for configuring gopassbridge as described at https://github.com/gopasspw/gopass/blob/master/docs/setup.md#filling-in-passwords-from-browser does not produce the expected result:

Expected:

Running the command shows the configuration options:

gopass jsonapi configure

Actual:

Running the command above performs a repository search for jsonapi.

Notes:

Apparently, either the docs or the lastest gopass are out of sync.

icyd commented 4 years ago

gopass-jsonapi is a need binary by itself now, if you are using the source in the base folder cd cmd/gopass-jsonapi and do go build && go install, the command gopass-jsonapi should be available under your go/bin folder.

glowinthedark commented 4 years ago

@icyd:

Thank you so much! The instructions you provided worked, ran gopass-jsonapi configure -> chrome and the extension started working for brave (it's a weird brave defect that it only works when specifying chrome rather than brave)

But the docs are still out of sync which is misleading for anyone trying to follow them.

Also, for some reason the gopass bridge extension now shows the warning; Please update gopass to version 1.8.5 or newer.

Output of of gopass -v:

gopass 1.9.3-git+HEAD

I did check for leftover gopass binaries with which -a gopass.

icyd commented 4 years ago

Glad to here that! Yes, the documentation doesn't reflect this steps, also the release binaries, don't contain this command pre-build.

icyd commented 4 years ago

If you use the release binary 1.9.2, the command is still available gopasspw/gopass#1471

Pharb commented 4 years ago

Thanks for reporting this upcoming incompatibility. I can confirm that as long as you are using gopass v1.9.2. this will not be an issue.

Of course eventually 1.9.3 will break the current "jsonapi" setup.

To prepare for that we need to solve the "jsonapi configure" calls and how to access the "jsonapi" binary via native messaging for browser interactions.

Any help is very much appreciated.

Particularly one big issue might be if and how we have to maintain a separate "gopass-jsonapi" release binary and putting that into the established package managers most users probably use to install gopass.

Pharb commented 4 years ago

FYI: Upgrade steps for upcoming gopass 1.10 release are tracked in https://github.com/gopasspw/gopassbridge/issues/165