search

gopasspw / gopassbridge

A web extension for firefox and chrome to insert login credentials from gopass
MIT License
259 stars 23 forks source link

Add ungoogled-chromium browser value #189

Open erazemk opened 3 years ago

erazemk commented 3 years ago

This request stems from an issue mentioned in #188.

Ungoogled Chromium uses a custom ~/.config/ directory, so choosing chromium as a browser option in gopass-jsonapi configure doesn't work. Please consider adding an option for ungoogled chromium, which should copy the com.justwatch.gopass.json to $HOME/.config/ungoogled-chromium/NativeMessagingHosts/com.justwatch.gopass.json.

Pharb commented 3 years ago

Thank you for the suggestion. Sounds like a good improvement.

With the latest changes this issue belongs now to the gopass-jsonapi repository.

The code where we handle these browsers can be found here - I'm happy to review a PR there: https://github.com/gopasspw/gopass-jsonapi/blob/main/internal/jsonapi/manifest/setup_others.go#L18

@martinhoefling Do you maybe have the permissions to transfer this issue to the new gopass-jsonapi repository? Github just gives we strange errors when I try it :(

erazemk commented 3 years ago

@njenan I've recently switched to Brave, so I don't know where in /etc ungoogled-chromium stores messaging hosts, can you please tell me?

I'm guessing it something like /etc/ungoogled-chromium/native-messaging-hosts for the global path and ~/.config/ungoogled-chromium/NativeMessagingHosts for the local one, but I wanna be sure.