search

gopasspw / gopassbridge

A web extension for Firefox and Chrome to insert login credentials from gopass
MIT License
259 stars 24 forks source link

Run entry action on first result when pressing return key. #222

Closed tompre closed 2 years ago

tompre commented 2 years ago

Checking if elements contains at least one element should be enough to ensure safe behavior.

In this way, the first element can always be selected using the return key.

Fixes #219

codecov[bot] commented 2 years ago

Codecov Report

Merging #222 (01a8aa9) into master (1e4d246) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          722       722           
  Branches       120       120           
=========================================
  Hits           722       722
Impacted Files Coverage Δ
web-extension/search.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e4d246...01a8aa9. Read the comment docs.

martinhoefling commented 2 years ago

Thanks @tompre, seems like we didn't have a test before. Can you add one please?

martinhoefling commented 2 years ago

closing this one in favor of #223