search

gopaycommunity / gopay-dotnet-api

GoPay's .NET SDK for Payments REST API
6 stars 11 forks source link

net standard 2.1 update #14

Closed xixaoly closed 3 years ago

xixaoly commented 3 years ago
michaldivis commented 3 years ago

I'd like to support this PR. This is a much needed change.

michaldivis commented 3 years ago

This fixes my issue #15, please merge...

michaldivis commented 3 years ago

please merge this

xpetrik commented 3 years ago

It looks like @FSichinger died. Thank you @xixaoly for your work. We will use your PR and we will include source filles directly without nuget package.

FSichinger commented 3 years ago

Thanks for pull request and I apologize for late reply.

Next release will be available soon

jiripolasek commented 3 years ago

Hello, is it necessary to upgrade all the way to .NET Standard 2.1 only? It limits the possible audience to .NET Core/.NET only as there is no .NET Framework that supports .NET Standard 2.1. PR: #19

xpetrik commented 3 years ago

This is correct and necessary way to target both frameworks. @FSichinger will surely confirm this PR before he release nuget package

jiripolasek commented 3 years ago

The issue here is the version of .NET Standard used: targeting .NET Standard 2.0 (instead of 2.1) enables support for .NET Framework 4.6.1 - 4.8. Otherwise .NET Frameworks will be cut off.