search

gopaycommunity / gopay-dotnet-api

GoPay's .NET SDK for Payments REST API
6 stars 10 forks source link

RestSharp.Newtonsoft.Json downgraded to version 1.0.0 #6

Closed Florimond closed 7 years ago

Florimond commented 7 years ago

RestSharp.Newtonsoft.Json downgraded to version 1.0.0. Reason : compatibility with framework 4.5 Unit tests Ok.

FSichinger commented 7 years ago

Have you tested it against .NET 4.5.1/4.5.2. ? Are there any backwards incompatibilities between newtonsoft.json 8.0.2 and 9.0.1.

Florimond commented 7 years ago

The unit tests pass with all versions. Since it doesn't seem to make any difference for gopay-dotnet-api, my take is that choosing which version of Json to use could be left up to the user.

However, I've just upgraded Newtonsoft.Json from the version 8.0.3 to 9.0.1, which is the last version compatible with 4.5.

I successfully built the solution using .NET 4.5, 4.5.1, and 4.5.2. All unit tests passed every time.

FSichinger commented 7 years ago

Thanks, ill run unit tests once more and then eventually release 1.1.5 together with upcoming update which will include api calls for new supercash batch feature.