search

gophercloud / utils

Apache License 2.0
20 stars 55 forks source link

Use default transport settings for our custom TLS HTTP client #149

Closed mandre closed 3 years ago

mandre commented 3 years ago

f41c176 introduced a custom HTTP client to make use of the self-signed certificate specified in the clouds.yaml file. This change however removed all the settings that came with the DefaultTransport, including handling of proxy environment variables and default timeouts.

This commit ensures the custom HTTP client inherits its settings from the default transport.

Requires golang 1.13.

Fixes #148

EmilienM commented 3 years ago

This looks good to me.

pierreprinetti commented 3 years ago

LGTM! :+1:

kayrus commented 3 years ago

@jtopjian give me time till tomorrow. I'll review this.

mandre commented 3 years ago

Just want to make sure you folks saw this PR makes the minimum go version 1.13 and you're OK with it.

Fedosin commented 3 years ago

Minimum go version is 1.15 anyway: https://github.com/gophercloud/utils/blob/master/go.mod#L12