search

gophercloud / utils

Apache License 2.0
20 stars 55 forks source link

Replace hashicorp/go-uuid import with gofrs/uuid #211

Closed awels closed 5 months ago

awels commented 5 months ago

Replace import of hashicorp/go-uuid as its license MPL 2.0 is not incompatible with the license of the project Apache 2.0. Instead use gofrs/uuid which is compatible. It uses an MIT license.

pierreprinetti commented 5 months ago

I am not sure why MPL would be incompatible with this project, but I like the idea of switching to a compliant UUIDv4 generator. What do you think of https://github.com/gofrs/uuid which is also MIT?

awels commented 5 months ago

MPL 2.0 is not compatible with Apache 2.0. The project I work on has a license scanner and it flagged the go-uuid dependency as incompatible. I traced it coming from gophercloud as we don't import it ourselves.

I am fine with gofrs. I picked the google one, but if you prefer gofrs that works for me.

pierreprinetti commented 5 months ago

Well, thank you then!

awels commented 5 months ago

Updated the PR to replace it with gofrs/uuid instead.