search

gophercloud / utils

Apache License 2.0
20 stars 55 forks source link

Add advanced openstack client with the logger support #91

Closed kayrus closed 5 years ago

kayrus commented 5 years ago

Resolves https://github.com/gophercloud/gophercloud/issues/1748 @ozerovandrei this PR requires your approval as well, since some logic and tests were taken from the https://github.com/terraform-providers/terraform-provider-openstack/blob/493f93252e8071f592f03ad2da3bdf4288dc365f/openstack/types.go

kayrus commented 5 years ago

@jtopjian ready for review

jtopjian commented 5 years ago

@kayrus Thanks! Overall this looks good.

How about we rename main.go to something like debugger.go or just client.go since main.go implies that it is a standalone executable. And maybe add a doc.go file to explain how to use it?

kayrus commented 5 years ago

@jtopjian done

kayrus commented 5 years ago

I have a doubt about the default no-cache option. Probably it is better to disable this header by default.

ozerovandrei commented 5 years ago

I also think that adding that header into the generic library it's not really a good idea since standard python-openstackclients don't do that.

It's better to add it in end services like terraform-provider.