search

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.
MIT License
3.83k stars 264 forks source link

update vendored copy of gomacro: adds interpreted interfaces and more... #104

Closed cosmos72 closed 6 years ago

cosmos72 commented 6 years ago

fixes crash on import of complicates packages as "gonum.org/v1/plot/plotter", and other improvements

cosmos72 commented 6 years ago

A doubt: the updated gomacro in this pull request now depends on github.com/peterh/liner to implement line-editing and history at prompt.

Shall I add another pull request to add a vendored copy of github.com/peterh/liner ?

go get github.com/gopherdata/gophernotes would work in both cases: either with or without a vendored copy of such library

cosmos72 commented 6 years ago

Redundant: most other pull requests, including https://github.com/gopherdata/gophernotes/pull/105 and https://github.com/gopherdata/gophernotes/pull/111, already contain this

cosmos72 commented 6 years ago

update: pull request https://github.com/gopherdata/gophernotes/pull/105 for MIME rendering (images, html...) is still under discussion.

In the meantime, it would be good to at least update the vendored gomacro without touching gophernotes code.

I prepared pull request https://github.com/gopherdata/gophernotes/pull/114 for this purpose.