search

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.
MIT License
3.85k stars 264 forks source link

Update gomacro #132

Closed fiorix closed 6 years ago

fiorix commented 6 years ago

gomacro is one of the vendor'ed dependencies of gophernotes. I'd like to update it to get https://github.com/cosmos72/gomacro/pull/33 in gophernotes.

Tested locally, works as expected.

cosmos72 commented 6 years ago

I happen to know :)

For the moment, gophernotes uses gomacro stable branch not to pull in (experimental) generics - but that's not a problem, as I backported the same fix also to gomacro stable

fiorix commented 6 years ago

Ah. You're ahead of me. I didn't even realize :)

I guess you can drop my pull request then. Can you release a new tag v1.0.0-RC2 or something?

cosmos72 commented 6 years ago

Yes, it's time for a new release - there are already a lot of changes and improvements since the last one. Thanks for reminding :)

I am a bit busy RL, but I should manage in the next days.

QuLogic commented 6 years ago

Any time for a new tag perhaps?