search

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.
MIT License
3.82k stars 265 forks source link

Vendoring of gomacro makes gophernotes complain about gomacro location #136

Closed kortschak closed 6 years ago

kortschak commented 6 years ago

Currently the README says that the success of gophernotes installation can be checked with gophernotes and shows a clear reason for a run failure. Now gophernotes vendors gomacro; this means that gomacro is not necessarily in the location that gomacro will look for itself.

I guess this means that either the vendored copy needs to be modified, or gomacro needs to get smarter about the possibility that it has been vendored.

/cc @cosmos72

ghost commented 6 years ago

Try runpkg golang package.

It gets around this specific problem well if I understand the issue correctly.

On Tue, 7 Aug 2018, 08:48 Dan Kortschak, notifications@github.com wrote:

Currently the README says that the success of gophernotes installation can be checked with gophernotes and shows a clear reason for a run failure. Now gophernotes vendors gomacro; this means that gomacro is not necessarily in the location that gomacro will look for itself https://github.com/gopherdata/gophernotes/blob/053926923734fb2deb8a533b7b469c83d0641d53/vendor/github.com/cosmos72/gomacro/base/util.go#L140 .

I guess this means that either the vendored copy needs to be modified, or gomacro needs to get smarter about the possibility that it has been vendored.

/cc @cosmos72 https://github.com/cosmos72

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gopherdata/gophernotes/issues/136, or mute the thread https://github.com/notifications/unsubscribe-auth/ATuCwhG2fxcz4V7ZSJVNezMyn48Fx0Wqks5uOThJgaJpZM4VxlJb .