Please consider removing github.com/satori/go.uuid

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.

MIT License

3.82k stars 265 forks source link

Please consider removing github.com/satori/go.uuid #142

Open AlekSi opened 6 years ago

AlekSi commented 6 years ago

https://github.com/satori/go.uuid/issues/73 https://github.com/satori/go.uuid/issues/84

cosmos72 commented 5 years ago

It's a known problem, and gophernotes contains a patched satori/go.uuid to fix that specific bug - see commit 6474b0bfbaf2bfb865cf1a52be5a5a85a7b2e239

A better (better maintained?) uuid implementation would certainly help, you're welcome to indicate one.

AlekSi commented 5 years ago

How about https://github.com/gofrs/uuid?

sbinet commented 5 years ago

even if the gofrs organization is still a rather new endeavour, I'd be inclined to go with it.

cosmos72 commented 5 years ago

Looks good to me