search

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.
MIT License
3.82k stars 265 forks source link

Updated README with corrected docker command #153

Closed yonomitt closed 5 years ago

yonomitt commented 5 years ago

This PR updates the README.md file with, what I think is, the correct docker command to run gophernotes with data science packages.

It looks like the current command in the readme is the old way to do it, as it's pointing to an image that's over a year old.

sbinet commented 5 years ago

I'd assume this is a typo that sneaked in during the creation of that docker image.

$> docker images | grep gophernotes
gopherdata/gophernotes      latest-ds           dbebe6520835        3 weeks ago         1.06GB
gopherdata/gophernotes-ds   latest              b802a16d72e3        13 months ago       1.02GB

@dwhitena @SpencerPark @cosmos72 ?

sbinet commented 5 years ago

(and by typo, I mean gopherdata/gophernotes-ds:lastest is the expected image, but should be updated to the latest version, ie: dbebe6520835.)

yonomitt commented 5 years ago

If it helps, I had found out about the latest-ds tag from this comment:

https://github.com/gopherdata/gophernotes/issues/125#issuecomment-404302163

sbinet commented 5 years ago

ah! :) I stand corrected then.

SpencerPark commented 5 years ago

Indeed the automated build setup caused a slight change in the docker structure. The gopherdata/gophernotes images are updated on changes to master with the latest-ds tag building the Dockerfile.DS. We left the old one in case other images used it but it is very stale now.