[ABOUT BUILD] go mod may effect the kernel/kernel.json place

[yutiansut]

@sbinet

the kernel.json used to be inplaced in /go/src/

which in Dockerfile

    && mkdir -p ~/.local/share/jupyter/kernels/gophernotes \
    && cp -r /go/src/github.com/gopherdata/gophernotes/kernel/* ~/.local/share/jupyter/kernels/gophernotes \
    ## clean

while in 0.5 version, gophernotes been installed as a go mod, while actually the kernel.json in

/root/go/pkg/mod/github.com/gopherdata/gophernotes@v0.5.0/kernel

so maybe affected by this change

maybe change this to

RUN cd ~/.local/share/jupyter/kernels/gophernotes \
  && wget https://raw.githubusercontent.com/gopherdata/gophernotes/master/kernel/kernel.json \
  && wget https://raw.githubusercontent.com/gopherdata/gophernotes/master/kernel/logo-32x32.png \
 && https://raw.githubusercontent.com/gopherdata/gophernotes/master/kernel/logo-64x64.png 

would be better

[sbinet]

there's this line in Dockerfile:

ADD . /go/src/github.com/gopherdata/gophernotes/

so line 40 is expected to be fine whatever the "build mode" of Go.

[yutiansut]

opts~ thanks~

[yutiansut]

finnally ok~ @sbinet thanks for your help again~~

[cosmos72]

Update: I am working on Go 1.11 modules support for both gomacro and gophernotes:

https://github.com/gopherdata/gophernotes/pull/189 also contains module-related fixes to Dockerfile and Dockerfile.DS

[cosmos72]

Should be fixed now that https://github.com/gopherdata/gophernotes/pull/189 is merged