all: use pure-Go implementation of zmq4

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.

MIT License

3.8k stars 264 forks source link

all: use pure-Go implementation of zmq4 #195

Closed sbinet closed 4 years ago

sbinet commented 4 years ago

Fixes #199

sbinet commented 4 years ago

this should enable an easier installation process on all platforms (as the C/C++ ZMQ0 library isn't needed anymore).

would be great to have (especially) Windows & macOS users give this a spin.

sbinet commented 4 years ago

FYI, I plan to:

[x] rebase this PR to use go-zeromq/zmq4@v0.8.0 (when it's out: it's including a couple of bugfixes that could be relevant for this issue.)
[x] merge that PR a week after that rebase has happened (baring nobody reviewed/commented on it by then, of course)

cosmos72 commented 4 years ago

Thanks @sbinet, this is a very welcome improvement! I will review it ASAP

sbinet commented 4 years ago

PTAL.

sbinet commented 4 years ago

if nobody screams by Monday the 9th, I'll merge that in.

mattn commented 4 years ago

I tested this on Windows 64bit. Go 1.14 (tip). It works with importing standard packages. But importing external packages will be difficult on Windows since gomacros currently does not support dynamic import. (But this is not an issue of gophernotes and gomacros)

sbinet commented 4 years ago

I think we can also remove the "Make sure you have the MinGW toolchain: ..." from the README as that toolchain was for building with the c dependencies.

done.

sbinet commented 4 years ago

merged and tagged (v0.7.0). thanks everybody :)

sbinet commented 4 years ago

(@mattn could you devise an issue to reproduce this failure wrt stdin?)