Missing Windows support

gopherdata / gophernotes

The Go kernel for Jupyter notebooks and nteract.

MIT License

3.83k stars 264 forks source link

Missing Windows support #56

Closed wdscxsj closed 7 years ago

wdscxsj commented 7 years ago

First of all, thanks a lot for this amazing project. But Windows support is missing... I can prepare a PR if it helps.

AFAIK, the change is minimal:

conditionally disabled 7 lines involving pkg-config in vendor/github.com/alecthomas/gozmq
use a .bat file to set CGO_CFLAGS and CGO_LDFLAGS before invoking go build

Including pre-built zmq binaries may be convenient. Or even provide gophernotes.exe for download? :smile:

dwhitena commented 7 years ago

@wdscxsj, sorry I was out on vacation last week. Yes, I haven't considered Windows yet, and if you could PR, that would be amazing and much appreciated! I don't have a windows machine to test.

wdscxsj commented 7 years ago

@dwhitena, PR submitted. This is my first PR on GitHub, so please don't hesitate to point out anything improper.

In particular, prebuilt zmq dependency is included, because not all Windows users like to configure and build C/C++ code.

Quite awkwardly, to link to zmq, MinGW or something else has to be used... Maybe prebuilt gophernotes programs for Windows?

(It's late in my time zone now. I'll pick up your suggestion tomorrow and refine the PR.)

wdscxsj commented 7 years ago

Glad the PR helps. Closing this issue now.